Android component updater #2484
Conversation
| base::Bind(base::IgnoreResult( | ||
| &OnBeforeURLRequestDispatchOnIOThread), next_callback, ctx)); | ||
| // TODO(bridiver) - fix this | ||
| OnBeforeURLRequestAdBlockTP(ctx); |
There was a problem hiding this comment.
Can you elaborate on what you want to fix here?
There was a problem hiding this comment.
actually the comment can just be removed, I had that there as a reminder from before our conversation
bridiver
force-pushed
the
android-component-updater
branch
from
976fa95
to
396a587
Compare
bridiver
force-pushed
the
android-component-updater
branch
from
fb77ddd
to
4d5a958
Compare
bridiver
force-pushed
the
android-component-updater
branch
from
4d5a958
to
886dc91
Compare
| } | ||
|
|
||
| void TrackingProtectionService::UpdateFirstPartyStorageTrackers( | ||
| std::vector<std::string>) { |
There was a problem hiding this comment.
std::vector<std::string> storage_trackers
| if (storage_trackers_buffer_.empty()) { | ||
| LOG(ERROR) << "Could not obtain tracking protection data"; | ||
| void TrackingProtectionService::OnGetSTPDATFileData(std::string contents) { | ||
| DCHECK_CURRENTLY_ON(BrowserThread::IO); |
There was a problem hiding this comment.
Remove, since this is on main thread now.
| @@ -30,6 +30,10 @@ namespace brave_shields { | |||
| // checking and init. | |||
| class AdBlockBaseService : public BaseBraveShieldsService { | |||
| public: | |||
| using GetDATFileDataResult = | |||
There was a problem hiding this comment.
can we also have template< typename T > using GetDATFileDataResult = std::pair<std::unique_ptr<T>, brave_component_updater::DATFileDataBuffer> in components/brave_component_updater/browser/dat_file_util.h ?
also apply to AutoplayWhitelistService, ExtensionWhitelistService and TrackingProtectionService
bridiver
dismissed
SergeyZhukovsky’s stale review
he resolved them, not sure why this is still saying he requested changes
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.